Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a more specific error on I/O timeouts. #1340

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Add a more specific error on I/O timeouts. #1340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions internal/fnapi/fnapi.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,11 @@ func (c Call[RequestT]) Do(ctx context.Context, request RequestT, resolveEndpoin

response, err := client.Do(httpReq)
if err != nil {
// https://cs.opensource.google/go/go/+/master:src/net/net.go;l=628;drc=869932d700cf161c19eec65d66b9fe55482698db
if errors.Is(err, context.DeadlineExceeded) {
return fnerrors.InvocationError("namespace api", "unable to contact %v: %w", endpoint, err)
}

return fnerrors.InvocationError("namespace api", "http call failed: %w", err)
}

Expand Down
Loading