Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that pod observer never acts on stale watch events #1328

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Ensure that pod observer never acts on stale watch events #1328

merged 2 commits into from
Sep 17, 2024

Conversation

n-g
Copy link
Contributor

@n-g n-g commented Sep 17, 2024

No description provided.

@n-g
Ensure that pod observer never acts on stale watch events.
07a4b46 
When doing a watch with no minimum resource version, we can see stale events and falsely conclude that a pod is running which is already terminating.

Fixes NSL-4184
@n-g
back to debug
d11ff99
@n-g n-g requested a review from hugosantos September 17, 2024 14:28
@n-g n-g enabled auto-merge September 17, 2024 14:29
@n-g n-g added this pull request to the merge queue Sep 17, 2024
@n-g n-g removed this pull request from the merge queue due to a manual request Sep 17, 2024
@n-g n-g added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit 155fe4b Sep 17, 2024
21 of 22 checks passed
@n-g n-g deleted the niklas-pod-observe-stale-watch branch September 17, 2024 14:40
hugosantos
hugosantos reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@hugosantos hugosantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

But I would have lifted pkg/listandwatch from internal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugosantos hugosantos hugosantos left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n-g @hugosantos