integrations/golang: Use full package paths when building. #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carefully tracking the path to the built package within the Go module allows us to refer to binaries in a build plan across modules.
Previously given the following specification in example.com/foo/xxx/binary.cue
build_plan: [{binary: "example.com/bar/yyy"}]
we would try to build a package with the desired local name (yyy), but within the "calling" module (example.com/foo/yyy).
hugosantos
approved these changes
Sep 9, 2024
So that we can build an image out of it.
nichtverstehen
force-pushed
the
kirill/crossmodule
branch
from
c8e9048
to
2c105a1
Compare
|
I've tried build a few binaries in various locations including in workspace submodules and it seems that all works. 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carefully tracking the path to the built package within the Go module allows us to refer to binaries in a build plan across modules.
Previously given the following specification in example.com/foo/xxx/binary.cue
we would try to build a package with the desired local name (yyy), but within the "calling" module (example.com/foo/yyy).