protect against overflow

namespacelabs · Jul 31, 2024 · f1b1f4f · f1b1f4f
1 parent 8ab201f
commit f1b1f4f
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/internal/build/buildkit/logging.go b/internal/build/buildkit/logging.go
@@ -22,6 +22,8 @@ import (
 	"namespacelabs.dev/foundation/std/tasks/idtypes"
 )
 
+const maxJsonEventLength = 64 * 1024 * 1024
+
 var TaskOutputBuildkitJsonLog = tasks.Output("buildkit.json", "application/json+fn.buildkit")
 
 var UsePlaintextLogging = false
@@ -244,6 +246,11 @@ func pushJsonEvent(w io.Writer, ev jsonEvent) error {
 	if err != nil {
 		return err
 	}
+
+	if len(p) > maxJsonEventLength {
+		return fmt.Errorf("json event too large")
+	}
+
 	// Make a space for a newline, easier to parse.
 	pline := make([]byte, len(p)+1)
 	copy(pline, p)