Show namespace in Manage Names tab #486
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyRand
force-pushed
the
qt-manage-names-namespace
branch
2 times, most recently
from
d4f51b2
to
6966912
Compare
|
Tested; works fine. |
JeremyRand
changed the title
JeremyRand
force-pushed
the
qt-manage-names-namespace
branch
from
6966912
to
cc0080a
Compare
JeremyRand
changed the title
|
@domob1812 This is ready for review. |
domob1812
approved these changes
Jan 9, 2023
| case NameNamespace::IdentityData: | ||
| return tr("Identity data %1").arg(desc); | ||
| case NameNamespace::NonStandard: | ||
| return tr("Non-standard name %1").arg(desc); |
There was a problem hiding this comment.
Out of curiosity, I remember already seeing code like this, but I can't find it in the current codebase. Was that just another PR or am I simply mistaken here? Of course if we already have a switch to generate text representations, we should reuse it, but seems we don't, so this is fine.
There was a problem hiding this comment.
There's something mildly similar in transactiontablemodel.cpp, but it's for generating a text representation of the namespace without the rest of the name. That might be what you were thinking of?
JeremyRand
force-pushed
the
qt-manage-names-namespace
branch
from
cc0080a
to
0152fab
Compare
|
@domob1812 Feel free to merge this if it passes your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.