Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ONE_TIME_CHARGE notification type; bug fix for README example #54

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

64bit
Copy link
Contributor

@64bit 64bit commented Aug 8, 2024

Issue being fixed or feature implemented

added
Apple added ONE_TIME_CHARGE notification type for one-time non-recurring purchases ref

fixed
Make fields of APIException public so that example in README works, also fix typo res to response in the README example

What was done?

How Has This Been Tested?

ONE_TIME_CHARGE notification tested in Sandbox

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

@tikhop
Copy link
Contributor

tikhop commented Aug 9, 2024

@64bit LGTM, thank you for the PR. I will publish a new version in a bit.

@tikhop tikhop merged commit 49dcbc8 into namecare:master Aug 9, 2024
1 check passed
@64bit
Copy link
Contributor Author

64bit commented Aug 9, 2024

I see it on crates.io, thank you for publishing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants