Skip to content

Commit

Permalink
chore: fix golangci-lint (#307)
Browse files Browse the repository at this point in the history
  • Loading branch information
nakamasato authored Jul 25, 2024
1 parent 6ac8e1e commit 50c12c9
Show file tree
Hide file tree
Showing 6 changed files with 38 additions and 28 deletions.
File renamed without changes.
15 changes: 15 additions & 0 deletions .golangci.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
run:
timeout: 5m # default is 1m
issues:
exclude-rules:
- path: contents/kubernetes-operator/controller-runtime/
linters:
- errcheck

- path: contents/kubernetes-extensions/kubernetes-scheduler/random-scheduler
linters:
- errcheck

- path: contents/kubernetes-operator/client-go/
linters:
- errcheck
6 changes: 3 additions & 3 deletions contents/kubernetes-operator/client-go/indexer/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -110,11 +110,11 @@ func exampleWithThreadSafeMap() {
}

func nameIndexer(obj interface{}) ([]string, error) {
switch obj.(type) {
switch v := obj.(type) {
case string:
return []string{obj.(string)}, nil
return []string{v}, nil
case User:
return []string{obj.(User).Name}, nil
return []string{v.Name}, nil
default:
return []string{}, errors.New("nameIndexer error")
}
Expand Down
22 changes: 10 additions & 12 deletions contents/kubernetes-operator/client-go/listerwatcher/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -120,19 +120,17 @@ Code: You can get the event through `w.ResultChan()`. The example is simplified
}
loop:
for {
select {
case event, ok := <-w.ResultChan():
if !ok {
break loop
}

meta, err := meta.Accessor(event.Object)
if err != nil {
continue
}
resourceVersion := meta.GetResourceVersion()
klog.Infof("event: %s, resourceVersion: %s", event.Type, resourceVersion)
event, ok := <-w.ResultChan()
if !ok {
break loop
}

meta, err := meta.Accessor(event.Object)
if err != nil {
continue
}
resourceVersion := meta.GetResourceVersion()
klog.Infof("event: %s, resourceVersion: %s", event.Type, resourceVersion)
}
```

Expand Down
20 changes: 9 additions & 11 deletions contents/kubernetes-operator/client-go/listerwatcher/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,18 +70,16 @@ func main() {
}
loop:
for {
select {
case event, ok := <-w.ResultChan():
if !ok {
break loop
}
event, ok := <-w.ResultChan()
if !ok {
break loop
}

meta, err := meta.Accessor(event.Object)
if err != nil {
continue
}
resourceVersion := meta.GetResourceVersion()
klog.Infof("event: %s, resourceVersion: %s", event.Type, resourceVersion)
meta, err := meta.Accessor(event.Object)
if err != nil {
continue
}
resourceVersion := meta.GetResourceVersion()
klog.Infof("event: %s, resourceVersion: %s", event.Type, resourceVersion)
}
}
3 changes: 1 addition & 2 deletions doc/doc.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package doc

import (
"fmt"
"io/ioutil"
"os"
"strings"
)
Expand Down Expand Up @@ -103,7 +102,7 @@ func (m *MarkDownDoc) WriteTable(t *Table) *MarkDownDoc {
}

func (m *MarkDownDoc) Export(filename string) error {
return ioutil.WriteFile(filename, []byte(m.builder.String()), os.ModePerm)
return os.WriteFile(filename, []byte(m.builder.String()), os.ModePerm)
}

func (m *MarkDownDoc) GetLink(desc, url string) string {
Expand Down

0 comments on commit 50c12c9

Please sign in to comment.