Remove sorting of risk score for now

nais · Sep 10, 2024 · 414a600 · 414a600
1 parent 9a68b6f
commit 414a600
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/internal/v1/graphv1/schema/applications.graphqls b/internal/v1/graphv1/schema/applications.graphqls
@@ -89,9 +89,6 @@ enum ApplicationOrderField {
 	"Order applications by the name of the environment."
 	ENVIRONMENT
 
-	"Order applications by the risk score."
-	RISK_SCORE
-
 	"Order applications by the deployment time."
 	DEPLOYMENT_TIME
 }
diff --git a/internal/v1/workload/application/models.go b/internal/v1/workload/application/models.go
@@ -40,13 +40,12 @@ const (
 	ApplicationOrderFieldName           ApplicationOrderField = "NAME"
 	ApplicationOrderFieldStatus         ApplicationOrderField = "STATUS"
 	ApplicationOrderFieldEnvironment    ApplicationOrderField = "ENVIRONMENT"
-	ApplicationOrderFieldRiskScore      ApplicationOrderField = "RISK_SCORE"
 	ApplicationOrderFieldDeploymentTime ApplicationOrderField = "DEPLOYMENT_TIME"
 )
 
 func (e ApplicationOrderField) IsValid() bool {
 	switch e {
-	case ApplicationOrderFieldStatus, ApplicationOrderFieldName, ApplicationOrderFieldEnvironment, ApplicationOrderFieldRiskScore, ApplicationOrderFieldDeploymentTime:
+	case ApplicationOrderFieldStatus, ApplicationOrderFieldName, ApplicationOrderFieldEnvironment, ApplicationOrderFieldDeploymentTime:
 		return true
 	}
 	return false

diff --git a/internal/v1/workload/application/queries.go b/internal/v1/workload/application/queries.go
@@ -36,10 +36,10 @@ func ListForTeam(ctx context.Context, teamSlug slug.Slug, page *pagination.Pagin
 		slices.SortStableFunc(ret, func(a, b *Application) int {
 			return modelv1.Compare(a.EnvironmentName, b.EnvironmentName, orderBy.Direction)
 		})
-	case ApplicationOrderFieldRiskScore:
-		panic("not implemented yet")
 	case ApplicationOrderFieldDeploymentTime:
-		panic("not implemented yet")
+		slices.SortStableFunc(ret, func(a, b *Application) int {
+			return modelv1.Compare(a.EnvironmentName, b.EnvironmentName, orderBy.Direction)
+		})
 	case ApplicationOrderFieldStatus:
 		panic("not implemented yet")
 	}