Fix code paths -- on() should succeed and off() should fail

n8henrie · Feb 19, 2024 · 61e6b40 · 61e6b40
1 parent ec9abf0
commit 61e6b40
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/tests/test_commandlineplugin.py b/tests/test_commandlineplugin.py
@@ -94,13 +94,9 @@ def test_commandlineplugin_fake_state() -> None:
             state = device.get_state()
             assert state == conf_initial_state
 
-        if device.on():
-            assert device.get_state() == "on"
-        else:
-            assert device.get_state() == state
+        # Tests are arranged so that `on()` succeeds and `off()` fails
+        assert device.on()
+        assert device.get_state() == "on"
 
-        state = device.get_state()
-        if device.off():
-            assert device.get_state() == "off"
-        else:
-            assert device.get_state() == state
+        assert not device.off()
+        assert device.get_state() == "on"