-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ResultSet packing #13
Implement ResultSet packing #13
Conversation
This pr addresses the error in #6. Additionally, it implements the predicate push-up optimisation as described in #5, i.e. we delay filtering data points as far as possible until the number of series to filter is minimised. Query evaluation now works on the following test case. Say we're given 3 data points:
And the following select query:
This gives us the correct sorted results:
. Additionally, we can evaluate more complex queries such as with an "AND" statement here
which returns the correct single data point:
|
We return an empty set instead, so that we can continue receiving results.
@n-young rebased and ready for review! |
r1.union(r2, shared_block); | ||
r1.unpack(shared_block); | ||
r1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Union returns an unpacked, so this unpack shouldn't do anything right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah not necessarily: if a union encounters two packed ResultSets, AND both ResultSets don't have filters, then it doesn't unpack them.
LGTM! Sorry this took so long to review :( |
No description provided.