Restore OMF-5 backward compatibility #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Map old bindProperty to setProperty, and issue a warning that it is deprecated; * Don't complain about 'version' is deprecated and not supported; * Use path instead of bin_path; fixes: #1804 Signed-off-by: Olivier Mehani <[email protected]>
| @@ -24,6 +24,11 @@ def initialize(name, group) | |||
| end | |||
| end | |||
|
|
|||
| def bindProperty(key, property_value) | |||
There was a problem hiding this comment.
Actually bindProperty is now supported in OMF 6. From my understanding, and from the example in http://oml.mytestbed.net/issues/1804, it is related to Prototype... which has been ported into 6. The definition of bindProperty is at omf_ec/lib/omf_ec/context/app_context.rb +115 under commit 77bad4d.
May I suggest NOT map bindProperty to setProperty for now, and assume that bindProperty is used for Prototype only.
Signed-off-by: Olivier Mehani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1804
http://oml.mytestbed.net/issues/1804
Signed-off-by: Olivier Mehani [email protected]