added support for accurate reminder time #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #679 +/- ##
=======================================
Coverage 92.97% 92.97%
=======================================
Files 74 74
Lines 1937 1937
Branches 286 286
=======================================
Hits 1801 1801
Misses 131 131
Partials 5 5Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #679 +/- ##
=======================================
Coverage 92.97% 92.97%
=======================================
Files 74 74
Lines 1937 1937
Branches 286 286
=======================================
Hits 1801 1801
Misses 131 131
Partials 5 5Continue to review full report at Codecov.
|
dkhnn
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the ability to define reminders (medicine and toilets) at any time without limiting the minutes to be a multiple of 30 min.
This is critical according to the school stuff and it is also a bug (#579)