Re-use same outs & chosen mix outs across tx construction attempts #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upon completing round 1 of tx construction, the client determines if the fee used in the tx is > result of calculate_fee(). If not, it re-attempts the tx using the result of calculate_fee(). If the client does not re-use the same set of mix_outs from the prior attempt for each out, then the size of the transaction likely ends up being a little different (because transactions reference mix outs by on optimized offset, which varies in size depending on the set of mix outs), even though the attempt is targeting a fee for a transaction of an expected size. This can result in the transaction including a fee that is *not* the result of calculate_fee(final_tx). Thus, this change provides a way for the client to re-use mix outs across attempts, so that the final fee is equivalent ot the result of calculate_fee. This is now implemented the same way as wallet2 (which also re-uses the same set of decoys across attempts). Bonus: it avoids trips to the server to get new decoys every tx attempt as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: mymonero/mymonero-core-cpp#36