Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CODEOWNERS #57

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update CODEOWNERS #57

wants to merge 1 commit into from

Conversation

helixliam
Copy link
Contributor

Set CODEOWNERS to Cloud team instead of myhelix/engineering to avoid mass emailing all of engineering with PR update notification emails.

zubinmadon
zubinmadon approved these changes Nov 8, 2023
View reviewed changes
Copy link

@zubinmadon zubinmadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be good to have @myhelix/devops-team too since this is related to engineering as well

@corrjo
Copy link
Contributor

corrjo commented Nov 8, 2023

Would be worth getting @manasahelix and @harshithakandulahelix's input on this before merging

@helixliam
Copy link
Contributor Author

might be good to have @myhelix/devops-team too since this is related to engineering as well

It was set to DevOps for this repository in the past. I thought that the Cloud team replaced DevOps? Either way, I'm impartial to keeping the GitHub DevOps team around and continuing to use it for code owners and repo access control.

@corrjo
Copy link
Contributor

corrjo commented Nov 9, 2023

might be good to have @myhelix/devops-team too since this is related to engineering as well

It was set to DevOps for this repository in the past. I thought that the Cloud team replaced DevOps? Either way, I'm impartial to keeping the GitHub DevOps team around and continuing to use it for code owners and repo access control.

Hmm, Cloud didn't actually replace the devops team, the function was split. Really this sounds like a good guild topic, since there isn't a "devops team" that gh group doesn't have great ownership or rules around who would be in the group. I'm personally in favor of deprecating that group and starting a new one thats composed with a purpose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zubinmadon zubinmadon zubinmadon approved these changes

@ZuhaibSiddiqueHelix ZuhaibSiddiqueHelix ZuhaibSiddiqueHelix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@helixliam @corrjo @zubinmadon @ZuhaibSiddiqueHelix