Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid html in guidelines #47

Open
rettinghaus opened this issue Jul 7, 2018 · 12 comments · Fixed by #65
Open

Invalid html in guidelines #47

rettinghaus opened this issue Jul 7, 2018 · 12 comments · Fixed by #65

Comments

@rettinghaus
Copy link
Member

The Declaration fields in the guidelines, that present the ODD snippet, are invalid, because <div> is not allowed within <code>.

Example:
http://music-encoding.org/guidelines/dev/data-types/data.uneumename.html

@musicEnfanthen
Copy link
Member

musicEnfanthen commented Nov 6, 2018

Where did you find this information that <div> is not allowed within <code>? By definition, every html element should be allowed inside <code>?

@ahankinson
Copy link
Member

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/code

'Phrasing content' are the only allowed tags within <code>. If you want to embed other tags you have to character-encode them, e.g., &lt;div&gt;

@musicEnfanthen
Copy link
Member

I see. It's not allowed as genuine html tag.

If I understand it right, the divs and spans in the Declaration part are used for styling purposes (indentation, coloring)? How is it generated? Automatically?

@kepper
Copy link
Member

kepper commented Nov 7, 2018

All that is generated automatically on commit. However, the code in there is quite old, and has been adjusted several times to different needs (it's been generating the starting point for our Guidelines PDFs in the past, amongst other things). There have been all kinds of issues in the past, and given that I've essentially build a similar thing last week twice (the only hard part is resolving the various classes), I'm inclined to completely replace the XSLT with something more specific, including better documentation. This would address not only #47, but also #46, #59 and #35. With some assistance (probably by @ahankinson) it could also address (or at least prepare for) #28. I'm happy to do that, but won't be able before middle of next week.

@lpugin
Copy link
Member

lpugin commented Nov 7, 2018

Could we use LibMEI and have a guidelines output for it?

@ahankinson
Copy link
Member

Given that the libmei processor is essentially just a bunch of xpath queries in Python, I don't think there is much advantage to that over XSLT.

@kepper kepper self-assigned this Nov 18, 2018
@kepper
Copy link
Member

kepper commented Nov 18, 2018

just a brief update – I'm working on this (including #46, #59, #35 and potentially #28), and hope to have something ready for review soon. No need for someone else to pick these up

@rettinghaus
Copy link
Member Author

HTML errors/warnings

  • still div within code
  • div does not allow xml:space="preserve"
  • script may omit type attribute.

@kepper
Copy link
Member

kepper commented Dec 5, 2018 via email

@rettinghaus
Copy link
Member Author

Over two years later I thought it would be a good time to test again. Same as before with on severe new one:

  • Duplicate ID tipue_search_input.

See: https://validator.w3.org/nu/?doc=https%3A%2F%2Fmusic-encoding.org%2Fguidelines%2Fv4%2Felements%2Fbarline.html

@musicEnfanthen
Copy link
Member

Is this still an issue @rettinghaus ?

@rettinghaus
Copy link
Member Author

My comment above has lost none of its relevance.

@musicEnfanthen musicEnfanthen changed the title invalid html in guidelines Invalid html in guidelines Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants