Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve spec extraction #65

Merged
merged 11 commits into from
Dec 5, 2018
Merged

Improve spec extraction #65

merged 11 commits into from
Dec 5, 2018

Conversation

kepper
Copy link
Member

@kepper kepper commented Dec 5, 2018

This is an almost complete rewrite of the code that generates the spec pages. It depends on music-encoding/music-encoding.github.io#62 for correct rendition. Please have a close look before this gets merged. All links should stay the same, except for Macro Groups (<macroSpec type="pe">), which are now in a separate folder. I think this is acceptable, as per discussion on #64. If accepted, this branch probably

@ahankinson
Copy link
Member

How did you test it? (More importantly, how can we test it, short of merging and fixing?)

@kepper
Copy link
Member Author

kepper commented Dec 5, 2018

well, it runs on my machine, and it works well here. I don't know if the pipeline on Github picks it up properly, but afaik, we're using a Saxon there as well, so it should be ok. If you download both branches and run extractGuidelines.xsl against the canonicalized4.0.0.xml in the same folder (which is just a recent local copy of the compiled MEI sources), you can then serve both repos locally using Jekyll. It takes a while to compile everything, but then you should get the new version running locally.

@ahankinson ahankinson self-assigned this Dec 5, 2018
@ahankinson
Copy link
Member

I've run it on my machine and it seems to work. We're going to need to trigger a new build, though, which I can do.

@ahankinson ahankinson merged commit 049f8a2 into master Dec 5, 2018
@ahankinson ahankinson deleted the improve-spec-extraction branch December 5, 2018 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants