Fixed maya get data

Will now correctly assign the weights to the correct influence index
munkybutt · Sep 30, 2023 · e58fa36 · e58fa36
1 parent 9d6e3f8
commit e58fa36
Show file tree

Hide file tree

Showing 8 changed files with 7 additions and 8 deletions.
diff --git a/.gitignore b/.gitignore
@@ -445,7 +445,8 @@ PyProjects/source/vcpkg_installed/
 PyProjects/venv37/
 PyProjects/venv39/
 PyProjects/.venvs/
-/pypi/*
+build/
+pypi/
 temp.cpp
 *.exp
 *.max

diff --git a/PYProjects/skin_plus_plus/dccs/max/skin_plus_plus_pymxs_2023/skin_plus_plus_pymxs.pyd b/PYProjects/skin_plus_plus/dccs/max/skin_plus_plus_pymxs_2023/skin_plus_plus_pymxs.pyd
diff --git a/PYProjects/skin_plus_plus/dccs/max/skin_plus_plus_pymxs_2024/skin_plus_plus_pymxs.pyd b/PYProjects/skin_plus_plus/dccs/max/skin_plus_plus_pymxs_2024/skin_plus_plus_pymxs.pyd
diff --git a/PYProjects/skin_plus_plus/dccs/maya/skin_plus_plus_pymaya_2023/skin_plus_plus_pymaya.pyd b/PYProjects/skin_plus_plus/dccs/maya/skin_plus_plus_pymaya_2023/skin_plus_plus_pymaya.pyd
diff --git a/PYProjects/skin_plus_plus/dccs/maya/skin_plus_plus_pymaya_2024/skin_plus_plus_pymaya.pyd b/PYProjects/skin_plus_plus/dccs/maya/skin_plus_plus_pymaya_2024/skin_plus_plus_pymaya.pyd
diff --git a/PYProjects/skin_plus_plus/py/39/skin_plus_plus_py.pyd b/PYProjects/skin_plus_plus/py/39/skin_plus_plus_py.pyd
diff --git a/PYProjects/skin_plus_plus_test/skin_plus_plus_test.py b/PYProjects/skin_plus_plus_test/skin_plus_plus_test.py
@@ -677,7 +677,7 @@ def add_bones():
 
 if __name__ == "__main__":
     pass
-    skin_plus_plus.io.max_to_maya(file_type=skin_plus_plus.FileType.json)
+    skin_plus_plus.io.maya_to_max(file_type=skin_plus_plus.FileType.json)
     # skin_plus_plus
     # bones = ["one", "two"]
     # ids = np.array([[0, 1], [1, 0]], dtype=np.float64)

diff --git a/PYProjects/source/skin_plus_plus_pymaya/skin_plus_plus_pymaya.cpp b/PYProjects/source/skin_plus_plus_pymaya/skin_plus_plus_pymaya.cpp
@@ -202,16 +202,15 @@ PySkinData SkinManagerMaya::getData()
     {
         throw std::exception("SkinData object is invalid. Cannot get skin weights.");
     }
-    UINT vertexCount = this->fnMesh.numVertices();
+    const UINT vertexCount = this->fnMesh.numVertices();
     if (vertexCount == 0)
     {
         throw std::exception("Mesh has no vertices!");
     }
     MDoubleArray weights;
-    unsigned boneCount;
+    UINT boneCount;
     this->fnSkinCluster.getWeights(this->dagPath, this->component, weights, boneCount);
     PySkinData pySkinData = PySkinData(vertexCount, this->maximumVertexWeightCount);
-
     MDagPathArray skinnedBones;
     MStatus status;
     this->fnSkinCluster.influenceObjects(skinnedBones, &status);
@@ -229,10 +228,10 @@ PySkinData SkinManagerMaya::getData()
     for (UINT vertexIndex = 0; vertexIndex < vertexCount; vertexIndex++)
     {
         UINT influenceIndex = 0;
-        UINT weightIndex = vertexIndex * boneCount;
+        UINT weightIndexBase = vertexIndex * boneCount;
         for (UINT boneIndex = 0; boneIndex < boneCount; boneIndex++)
         {
-            weightIndex += boneIndex;
+            UINT weightIndex = weightIndexBase + boneIndex;
             double influenceWeight = weights[weightIndex];
             pySkinData.weights(vertexIndex, influenceIndex) = influenceWeight;
             pySkinData.boneIDs(vertexIndex, influenceIndex) = boneIndex;
@@ -328,7 +327,6 @@ MDoubleArray getWeightsAsMDoubleArray(BoneIDsMatrix boneIDs, WeightsMatrix weigh
 }
 
 
-
 bool SkinManagerMaya::setSkinWeights(PySkinData& skinData)
 {
     auto vertexCount = skinData.boneIDs.rows();