Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update postfix_mailvolume #1633

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexxroche
Copy link

Enable this plugin to additionally (optionally) read from the SystemD Journal

Tested on AlmaLinux 9.4

Enable this plugin to additionally (optionally) read from the SystemD Journal

Tested on AlmaLinux 9.4
Comment on lines +78 to +84
my ($LOGFILE, $rotated);

if ($USE_JC and $USE_JC == 1){
open $LOGFILE, '-|', $JC_CMD or die $!;
}else{
($LOGFILE, $rotated) = tail_open($fname, $start || 0);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some formatting fixes.

Suggested change
my ($LOGFILE, $rotated);
if ($USE_JC and $USE_JC == 1){
open $LOGFILE, '-|', $JC_CMD or die $!;
}else{
($LOGFILE, $rotated) = tail_open($fname, $start || 0);
}
my ($LOGFILE, $rotated);
if ($USE_JC and $USE_JC == 1) {
open $LOGFILE, '-|', $JC_CMD or die $!;
} else {
($LOGFILE, $rotated) = tail_open($fname, $start || 0);
}

Comment on lines +114 to +118
if ($USE_JC and $USE_JC == 1) {
return close($LOGFILE);
}else{
return tail_close($LOGFILE);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if ($USE_JC and $USE_JC == 1) {
return close($LOGFILE);
}else{
return tail_close($LOGFILE);
}
if ($USE_JC and $USE_JC == 1) {
return close($LOGFILE);
} else {
return tail_close($LOGFILE);
}

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10832442130

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.022%

Totals Coverage Status
Change from base Build 10714903398: 0.0%
Covered Lines: 1579
Relevant Lines: 2255

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants