Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve ${graph_period} in field labels #1565

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

niclan
Copy link
Contributor

@niclan niclan commented Jul 26, 2023

Also fix misunderstanding wrt rrdname vs label

Also fix misunderstanding wrt rrdname vs label
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5665899674

  • 0 of 9 (0.0%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.2%) to 50.876%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/Munin/Master/HTML.pm 0 4 0.0%
lib/Munin/Master/Graph.pm 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
lib/Munin/Master/HTML.pm 1 7.45%
lib/Munin/Master/Graph.pm 2 3.07%
lib/Munin/Master/UpdateWorker.pm 2 92.61%
Totals Coverage Status
Change from base Build 5462822496: -0.2%
Covered Lines: 1104
Relevant Lines: 2170

💛 - Coveralls

my $sth_sa = $dbh->prepare_cached("SELECT value FROM service_attr WHERE id = ? and name = ?");

$sth_sa->execute($service_id, 'graph_period');
my ($graph_period) = $sth_sa->fetchrow_array();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steveschnepp : any clue to why this prepare/execute returns a empty value?

Compare https://github.com/munin-monitoring/munin/blob/master/lib/Munin/Master/Graph.pm#L227 and the ds query further down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants