Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove possible "ignore" value from "use_node_name" #1140

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove possible "ignore" value from "use_node_name" #1140

wants to merge 2 commits into from

Commits on Jun 10, 2019

  1. Remove master configuration setting "use_default_node" 

    The setting was introduced in 6adf38a.

But somehow it partially lost its meaning in the merge commit
c8228b8 (Merge branch 'sql' into devel).
Afterwards it was only used for for breaking the node communication
in case of a missing "host" attribute (which can never be empty as
it is an integral part of the node specification in the master
configuration).  Thus it is not useful anymore.

The purpose of this setting was later replaced with
"use_node_name ignore" in dd4cbb5.
    @sumpfralle
    sumpfralle committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    33cb535 View commit details
    Browse the repository at this point in the history

  2. Remove "ignore" value for "use_node_name" 

    The additional value "ignore" was added in dd4cbb5.

It caused the following "list" commands to be sent to the node:
* "yes" -> "list $self->{node_name}"
* "ignore" -> "list "
* "no" -> "list $self->{host}"
* any other value -> "list $self->{host}"

The above "$self->{node_name}" is the name advertised by the node during
the opening of the connection.
"$self->{host}" is the name of the node section in the master
configuration.

The new behaviour is the following:
* "yes" -> "list"
* "ignore" -> "list"
* "no" -> "list $self->{host}"
* any other value -> "list $self->{host}"

This behaviour has the same effect as before, as the request for "list"
(without a specific node name) is handley by munin-node exactly, as if
its "node_name" is supplied.
    @sumpfralle
    sumpfralle committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    88e6b96 View commit details
    Browse the repository at this point in the history