Feature moderator take care of #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipecalvo
commented
Jun 10, 2021
felipecalvo
force-pushed
the
feature-moderator-ill-do-it
branch
from
4b57d33
to
0c98543
Compare
A moderator uses /discussion/:id/responsible to post their intention; the autogenerated responsible_*_discussion_path routes (with * being exercise, chapter or lesson) are not needed for this use case. I don't know why they're needed for subscription or upvotes either, but I don't want to risk breaking backwards compatibility as those features are not tested for some reason.
felipecalvo
force-pushed
the
feature-moderator-ill-do-it
branch
from
0c98543
to
344b832
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Adds the necessary buttons, texts and locales for letting a moderator take care of a discussion. Does not show last moderator access anymore.
📝 Details
📸 Screenshots
I'll take care of itbuttonConfirmation toast when clicking. Button changes to `I won't take care of it'
If another moderator beats you to it, there's also an error toast
You can see who's taking care of it on the discussion view
And also on the discussion index
Requires mumuki/mumuki-domain#218
🔙 Backwards compatibility
We're no longer showing a moderator's last access to a discussion, replacing it with who's taking care of it instead.
🔜 Future work
There's an unlikely to occur bug which can be solved by refreshing: #1626