Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable number of shards #460

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

sstanculeanu
Copy link
Contributor

Currently, the number of shards is computed based on the provided observers and reloading the configs with a different number of shards is not possible.

This may happen after an upgrade, where the observers from on shard may not be ready yet.

@sstanculeanu sstanculeanu self-assigned this Sep 4, 2024
miiu96
miiu96 previously approved these changes Sep 4, 2024
@raduchis raduchis self-requested a review September 4, 2024 10:19
cmd/proxy/main.go Outdated Show resolved Hide resolved
observer/testdata/config.toml Outdated Show resolved Hide resolved
observer/testdata/config.toml Show resolved Hide resolved
observer/baseNodeProvider.go Outdated Show resolved Hide resolved
observer/baseNodeProvider_test.go Outdated Show resolved Hide resolved
observer/circularQueueNodesProvider_test.go Show resolved Hide resolved
@sstanculeanu sstanculeanu merged commit 3232090 into rc/v1.7.next1 Sep 4, 2024
5 checks passed
@sstanculeanu sstanculeanu deleted the configurable_number_of_shards branch September 4, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants