Map counters holder component #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| availabilityProvider := availabilityCommon.AvailabilityProvider{} | ||
| dataAvailabilityTypes := availabilityProvider.GetAllAvailabilityTypes() | ||
|
|
||
| countersMap := make(map[data.ObserverDataAvailabilityType]*mapCounter) |
There was a problem hiding this comment.
Suggested change
| countersMap := make(map[data.ObserverDataAvailabilityType]*mapCounter) | |
| countersMap := make(map[data.ObserverDataAvailabilityType]*mapCounter, len(dataAvailabilityTypes)) |
| ) | ||
|
|
||
| // MapCountersHolder handles multiple counters map based on the data availability | ||
| type MapCountersHolder struct { |
There was a problem hiding this comment.
can be unexported and use an interface on circularQueueNodesProvider
| countersMap map[uint32]uint32 | ||
| counterForAllNodes uint32 | ||
| mutCounters sync.RWMutex | ||
| positionsHolder *mapCounters.MapCountersHolder |
There was a problem hiding this comment.
done. but didn't pass it to the constructor since the functionality of the circularQueueNodesProvider depends a lot on the actual implementation, so stubs in tests wouldn't help.
I just wanted to extract some code in new components so the code is easier to read :D
sstanculeanu
previously approved these changes
Sep 25, 2023
bogdan-rosianu
changed the base branch from
MX-14354-snapshotless-observers
to
feat/snapshotless-observer-support
bogdan-rosianu
dismissed
sstanculeanu’s stale review
The base branch was changed.
sstanculeanu
previously approved these changes
Sep 26, 2023
iulianpascalau
previously approved these changes
Sep 26, 2023
| return 0, errInvalidAvailability | ||
| } | ||
|
|
||
| if numNodes == 0 { |
There was a problem hiding this comment.
this can be placed on L37
|
|
||
| // ComputeShardPosition returns the shard position based on the availability and the shard | ||
| func (mch *mapCountersHolder) ComputeShardPosition(availability data.ObserverDataAvailabilityType, shardID uint32, numNodes uint32) (uint32, error) { | ||
| counterMap, exists := mch.countersMap[availability] |
There was a problem hiding this comment.
no protection needed because we set once and read many times
| return 0, errInvalidAvailability | ||
| } | ||
|
|
||
| if numNodes == 0 { |
There was a problem hiding this comment.
can be moved on L52
bogdan-rosianu
dismissed stale reviews from iulianpascalau and sstanculeanu
via
52e4e0c
iulianpascalau
approved these changes
Sep 26, 2023
sstanculeanu
approved these changes
Sep 26, 2023
gabi-vuls
approved these changes
Sep 29, 2023
bogdan-rosianu
merged commit bea1ef6
into
feat/snapshotless-observer-support
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added new components so we can have different circular queues for each observer type (normal / snapshotless)