[lite-client] Interceptor and recreate trie #6484
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # process/receiptslog/trieInteractor_test.go
# Conflicts: # process/receiptslog/receiptsManager.go # process/receiptslog/trieInteractor.go
# Conflicts: # process/receiptslog/trieInteractor.go
| } | ||
|
|
||
| // NewReceiptsManager will create a new instance of receipts manager | ||
| func NewReceiptsManager(args ArgsReceiptsManager) (*receiptsManager, error) { | ||
| if check.IfNil(args.TrieHandler) { | ||
| return nil, ErrNilTrieInteractor | ||
| } | ||
| if args.ReceiptsDataSyncer == nil { |
There was a problem hiding this comment.
Use check.IfNil(). Also, add a check for the marshaller and hasher
| } | ||
|
|
||
| func (rm *receiptsManager) syncBranchNodesData(receiptsRootHash []byte) (map[string][]byte, error) { | ||
| err := rm.receiptsDataSyncer.SyncReceiptsDataFor([][]byte{receiptsRootHash}, context.Background()) |
There was a problem hiding this comment.
L105 -> L113 and L127 -> L135 can be extracted in a common function
| db storage.Persister | ||
| } | ||
|
|
||
| func NewStorageManagerOnlyGet(db storage.Persister) (*storageManagerOnlyGet, error) { |
| return nil, nil | ||
| } | ||
|
|
||
| func (s storageManagerOnlyGet) PutInEpochWithoutCache(_ []byte, _ []byte, _ uint32) error { |
| return nil | ||
| } | ||
|
|
||
| func (s storageManagerOnlyGet) SetEpochForPutOperation(_ uint32) { |
process/receiptslog/trieRecreate.go
Outdated
| "github.com/multiversx/mx-chain-go/trie" | ||
| ) | ||
|
|
||
| // RecreateTrieFromDB will recreate the trie from the provided storer |
There was a problem hiding this comment.
Why is this not inside trieInteractor.go ?
|
|
||
| import "context" | ||
|
|
||
| type ReceiptsDataSyncerStub struct { |
trie/receiptsTrie.go
Outdated
|
|
||
| leafHashes = append(leafHashes, hashes...) | ||
|
|
||
| fmt.Println("here", len(nodeHash), len([]byte(nodeHash))) |
There was a problem hiding this comment.
Remove this print
trie/receiptsTrie.go
Outdated
| continue | ||
| } | ||
|
|
||
| leafHashes = append(leafHashes, hashes...) |
There was a problem hiding this comment.
These are not only leaf hashes. An intermediary node can have another intermediary node as a child. So basically you collect here every hash except for the root hash.
|
|
||
| err = manager.SyncReceiptsTrie(receiptsTrieHash) | ||
| require.Nil(t, err) | ||
| } |
There was a problem hiding this comment.
You should check that the correct data was synced.
There was a problem hiding this comment.
added check in receipts manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?