Proper fix for fee/initially paid fee for relayed after fix #6454

sstanculeanu · 2024-09-11T07:48:29Z

Reasoning behind the pull request

after base relayed fix flag activation, fee and initially paid fee fields of transaction withResults true, are still invalid due to being overwritten in specific scenarios

Proposed changes

skip the code that was doing the override

Testing procedure

standard system test + scenarios on fee/initially paid fee + @andreibancioiu rosetta scenarios

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

was the PR targeted to the correct branch?
if this is a larger feature that probably needs more than one PR, is there a feat branch created?
if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

codecov · 2024-09-11T07:55:42Z

Codecov Report

Attention: Patch coverage is 35.71429% with 9 lines in your changes missing coverage. Please review.

Project coverage is 78.66%. Comparing base (db3bb47) to head (0e3adbb).
Report is 115 commits behind head on rc/v1.7.next1.

Files with missing lines	Patch %	Lines
...rocess/transactionsfee/transactionsFeeProcessor.go	40.00%	4 Missing and 2 partials ⚠️
.../external/transactionAPI/gasUsedAndFeeProcessor.go	25.00%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@                Coverage Diff                @@
##           rc/v1.7.next1    #6454      +/-   ##
=================================================
- Coverage          78.73%   78.66%   -0.07%     
=================================================
  Files                755      755              
  Lines              99522    99796     +274     
=================================================
+ Hits               78357    78508     +151     
- Misses             15887    15993     +106     
- Partials            5278     5295      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-09-11T08:02:41Z

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

mx-chain-go Commit Hash: 0e3adbbb2a81955a82e87f83f10d0705e3f83916
Current Branch: proper_fee_fix_for_relayed_after_flag
mx-chain-go Target Branch: rc/v1.7.next1
mx-chain-simulator-go Target Branch: rc/v1.7.next1
mx-chain-testing-suite Target Branch: rc/v1.7.next1

🚀 Environment Variables:

TIMESTAMP: 11092024-080239
PYTEST_EXIT_CODE: 0
🎉 MultiversX CI/CD Workflow Complete!

github-actions · 2024-09-11T10:23:38Z

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

mx-chain-go Commit Hash: cfc8c78746bc60c8ed919c3f7b08788714dc5040
Current Branch: proper_fee_fix_for_relayed_after_flag
mx-chain-go Target Branch: rc/v1.7.next1
mx-chain-simulator-go Target Branch: rc/v1.7.next1
mx-chain-testing-suite Target Branch: rc/v1.7.next1

🚀 Environment Variables:

TIMESTAMP: 11092024-102336
PYTEST_EXIT_CODE: 1
🎉 MultiversX CI/CD Workflow Complete!

github-actions · 2024-09-11T10:25:39Z

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

mx-chain-go Commit Hash: 1f2d5930888ca7c98ff7ad052d9c765ad382c9ca
Current Branch: proper_fee_fix_for_relayed_after_flag
mx-chain-go Target Branch: rc/v1.7.next1
mx-chain-simulator-go Target Branch: rc/v1.7.next1
mx-chain-testing-suite Target Branch: rc/v1.7.next1

🚀 Environment Variables:

TIMESTAMP: 11092024-102537
PYTEST_EXIT_CODE: 1
🎉 MultiversX CI/CD Workflow Complete!

github-actions · 2024-09-11T10:37:47Z

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

mx-chain-go Commit Hash: 1f2d5930888ca7c98ff7ad052d9c765ad382c9ca
Current Branch: proper_fee_fix_for_relayed_after_flag
mx-chain-go Target Branch: rc/v1.7.next1
mx-chain-simulator-go Target Branch: rc/v1.7.next1
mx-chain-testing-suite Target Branch: rc/v1.7.next1

🚀 Environment Variables:

TIMESTAMP: 11092024-103745
PYTEST_EXIT_CODE: 1
🎉 MultiversX CI/CD Workflow Complete!

github-actions · 2024-09-11T10:53:48Z

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

mx-chain-go Commit Hash: 7becc67db2e307548cb0ebaf144d2141758b22fe
Current Branch: proper_fee_fix_for_relayed_after_flag
mx-chain-go Target Branch: rc/v1.7.next1
mx-chain-simulator-go Target Branch: rc/v1.7.next1
mx-chain-testing-suite Target Branch: rc/v1.7.next1

🚀 Environment Variables:

TIMESTAMP: 11092024-105346
PYTEST_EXIT_CODE: 1
🎉 MultiversX CI/CD Workflow Complete!

andreibancioiu · 2024-09-11T10:53:57Z

node/external/transactionAPI/gasUsedAndFeeProcessor.go

@@ -120,7 +125,8 @@ func (gfp *gasUsedAndFeeProcessor) handleRelayedV1(args [][]byte, tx *transactio
 	fee := gfp.feeComputer.ComputeTxFeeBasedOnGasUsed(tx, gasUsed)

 	innerFee := gfp.feeComputer.ComputeTransactionFee(&transaction.ApiTransactionResult{
-		Tx: innerTx,
+		Tx:    innerTx,
+		Epoch: tx.Epoch,


Tested on observer linked to Testnet ✔️

github-actions · 2024-09-11T11:56:14Z

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

mx-chain-go Commit Hash: 7becc67db2e307548cb0ebaf144d2141758b22fe
Current Branch: proper_fee_fix_for_relayed_after_flag
mx-chain-go Target Branch: rc/v1.7.next1
mx-chain-simulator-go Target Branch: rc/v1.7.next1
mx-chain-testing-suite Target Branch: rc/v1.7.next1

🚀 Environment Variables:

TIMESTAMP: 11092024-115612
PYTEST_EXIT_CODE: 1
🎉 MultiversX CI/CD Workflow Complete!

github-actions · 2024-09-11T20:00:52Z

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

mx-chain-go Commit Hash: 7becc67db2e307548cb0ebaf144d2141758b22fe
Current Branch: proper_fee_fix_for_relayed_after_flag
mx-chain-go Target Branch: rc/v1.7.next1
mx-chain-simulator-go Target Branch: rc/v1.7.next1
mx-chain-testing-suite Target Branch: rc/v1.7.next1

🚀 Environment Variables:

TIMESTAMP: 11092024-200051
PYTEST_EXIT_CODE: 1
🎉 MultiversX CI/CD Workflow Complete!

github-actions · 2024-09-12T06:36:33Z

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

mx-chain-go Commit Hash: 7becc67db2e307548cb0ebaf144d2141758b22fe
Current Branch: proper_fee_fix_for_relayed_after_flag
mx-chain-go Target Branch: rc/v1.7.next1
mx-chain-simulator-go Target Branch: rc/v1.7.next1
mx-chain-testing-suite Target Branch: rc/v1.7.next1

🚀 Environment Variables:

TIMESTAMP: 12092024-063631
PYTEST_EXIT_CODE: 0
🎉 MultiversX CI/CD Workflow Complete!

gabi-vuls

Normal allin test: 1.7.13-patch2-41962f78a1 -> proper_fee_fix_for_relayed-7becc67db2

--- Specific errors ---

block hash does not match 2004
wrong nonce in block 895
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 1
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 0
Nr. of all WARNS: 255
Nr. of new ERRORS: 0
Nr. of new WARNS: 0
Nr. of PANICS: 0

/------/

--- ERRORS ---

/------/

--- WARNINGS ---

/------/

proper fix for fee/initially paid fee for relayed after fix

0e3adbb

sstanculeanu added type:bug Something isn't working area:node-api Node API area:proxy-api complexity:trivial impact:low interested:protocol labels Sep 11, 2024

sstanculeanu self-assigned this Sep 11, 2024

sstanculeanu added 2 commits September 11, 2024 13:11

added unittest

cfc8c78

new line at the end of newly added test json

1f2d593

added missing epoch for inner tx

7becc67

andreibancioiu approved these changes Sep 11, 2024

View reviewed changes

sasurobert approved these changes Sep 11, 2024

View reviewed changes

miiu96 approved these changes Sep 11, 2024

View reviewed changes

AdoAdoAdo approved these changes Sep 11, 2024

View reviewed changes

gabi-vuls approved these changes Sep 13, 2024

View reviewed changes

sstanculeanu merged commit 50114c8 into rc/v1.7.next1 Sep 13, 2024
9 checks passed

sstanculeanu deleted the proper_fee_fix_for_relayed_after_flag branch September 13, 2024 07:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Proper fix for fee/initially paid fee for relayed after fix #6454

Proper fix for fee/initially paid fee for relayed after fix #6454

sstanculeanu commented Sep 11, 2024

codecov bot commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

andreibancioiu Sep 11, 2024

andreibancioiu Sep 11, 2024

github-actions bot commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

github-actions bot commented Sep 12, 2024

gabi-vuls left a comment

Proper fix for fee/initially paid fee for relayed after fix #6454

Proper fix for fee/initially paid fee for relayed after fix #6454

Conversation

sstanculeanu commented Sep 11, 2024

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

codecov bot commented Sep 11, 2024

Codecov Report

github-actions bot commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

andreibancioiu Sep 11, 2024

Choose a reason for hiding this comment

andreibancioiu Sep 11, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 11, 2024

github-actions bot commented Sep 11, 2024

github-actions bot commented Sep 12, 2024

gabi-vuls left a comment

Choose a reason for hiding this comment