-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate vm improve 1.5.5 #6139
Conversation
|
||
_, _ = vm.CreateAccount(testContext.Accounts, sndAddr, 0, senderBalance) | ||
|
||
tx := vm.CreateTransaction(0, big.NewInt(0), sndAddr, scAddress, gasPrice, gasLimit, []byte("increment")) | ||
|
||
res, err := testContext.TxCostHandler.ComputeTransactionGasLimit(tx) | ||
require.Nil(t, err) | ||
require.Equal(t, uint64(418), res.GasUnits) | ||
fmt.Println(res.GasUnits) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this print.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -74,6 +75,14 @@ func (uas *UserAccountStub) AddToBalance(value *big.Int) error { | |||
return nil | |||
} | |||
|
|||
// SubFromBalance - | |||
func (uas *UserAccountStub) SubFromBalance(value *big.Int) error { | |||
if uas.AddToBalanceCalled != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SubFromBalanceCalled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normal allin test: v1.6.15-dev-config-eb2e06c06d -> integrate-vm-improve-1.5.5-e26260c87e
--- Specific errors ---
block hash does not match 401
wrong nonce in block 291
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 0
Nr. of all WARNS: 230
Nr. of new ERRORS: 0
Nr. of new WARNS: 0
Nr. of PANICS: 0
/------/
--- ERRORS ---
/------/
--- WARNINGS ---
/------/
c00c31f
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.7.next1 #6139 +/- ##
=================================================
+ Coverage 78.74% 78.81% +0.07%
=================================================
Files 752 752
Lines 97976 98368 +392
=================================================
+ Hits 77153 77532 +379
- Misses 15584 15598 +14
+ Partials 5239 5238 -1 ☔ View full report in Codecov by Sentry. |
Reasoning behind the pull request
Enable more opcodes and options for developers.
Proposed changes
Integrate new crypto endpoints - BLS MultiSig, Secp256R1
Integrate new Opcodes for Relayer, OriginalCaller
Integrate TransferAndExecuteByUser for SovereignChains
Integrate EGLD in MultiTransfer
Testing procedure
System test every aspect noted before.
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
feat
branch created?feat
branch merging, do all satellite projects have a proper tag insidego.mod
?