Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sovereign] Add system sc code data #6129

Merged

Conversation

mariusmihaic
Copy link
Contributor

@mariusmihaic mariusmihaic commented Apr 22, 2024

Reasoning behind the pull request

  • Fix unknown async call error when a sc tries to call a meta chain sc address(like esdt issue)

Proposed changes

  • Reused init func for esdt sys accounts from epoch change flow
  • Fixed sovereign blockchain pointers in run type components

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@mariusmihaic mariusmihaic self-assigned this Apr 22, 2024
@mariusmihaic mariusmihaic changed the title Mx 15376 fix non payable by sc cross shard 2 Fix non payable by sc cross shard 2 Apr 22, 2024
Copy link
Contributor

@sasurobert sasurobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not a non payable fix - but add systemSC code data on genesis on Sovereign.

@mariusmihaic mariusmihaic changed the title Fix non payable by sc cross shard 2 [sovereign] Add system sc code data Apr 22, 2024
@mariusmihaic mariusmihaic merged commit fb43790 into feat/chain-go-sdk Apr 23, 2024
4 checks passed
@mariusmihaic mariusmihaic deleted the MX-15376-fix-non-payable-by-sc-cross-shard-2 branch April 23, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants