refactor RequesterContainerFactoryCreator #6088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
MX-15315-refactor-sov-runtype-comp-4
to
feat/refactor-runtype-components
April 16, 2024 14:01
…r-sov-runtype-comp-6 # Conflicts: # factory/interface.go # factory/runType/runTypeComponents.go # factory/runType/runTypeComponentsHandler.go # factory/runType/runTypeComponentsHandler_test.go # factory/runType/sovereignRunTypeComponents.go # testscommon/mainFactoryMocks/runTypeComponentStub.go
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/refactor-runtype-components #6088 +/- ##
====================================================================
- Coverage 78.17% 78.17% -0.01%
====================================================================
Files 874 874
Lines 103512 103539 +27
====================================================================
+ Hits 80917 80937 +20
- Misses 17106 17108 +2
- Partials 5489 5494 +5 ☔ View full report in Codecov by Sentry. |
raduchis
previously approved these changes
Apr 18, 2024
sasurobert
reviewed
Apr 22, 2024
| CreateCalled func() (dataRetriever.RequestersContainer, error) | ||
| } | ||
|
|
||
| func (s *ShardRequestersContainerFactoryMock) Create() (dataRetriever.RequestersContainer, error) { |
sasurobert
approved these changes
Apr 24, 2024
raduchis
approved these changes
Apr 24, 2024
axenteoctavian
merged commit 4599e4c
into
feat/refactor-runtype-components
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
RequesterContainerFactoryCreatorProposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?