Genesis accounts with esdt balances #5871
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feat/chain-go-sdk #5871 +/- ##
=====================================================
+ Coverage 79.38% 79.41% +0.02%
=====================================================
Files 790 789 -1
Lines 98473 98514 +41
=====================================================
+ Hits 78176 78231 +55
+ Misses 14817 14803 -14
Partials 5480 5480 ☔ View full report in Codecov by Sentry. |
mariusmihaic
changed the base branch from
feat/sovereign-esdt-native-payment
to
feat/chain-go-sdk
mariusmihaic
changed the base branch from
feat/chain-go-sdk
to
feat/sovereign-esdt-native-payment
mariusmihaic
changed the base branch from
feat/sovereign-esdt-native-payment
to
feat/chain-go-sdk
| @@ -55,8 +62,27 @@ func (gbc *sovereignGenesisBlockCreator) CreateGenesisBlocks() (map[uint32]data. | |||
| return gbc.createSovereignHeaders(argsCreateBlock) | |||
| } | |||
|
|
|||
| func (gbc *sovereignGenesisBlockCreator) initGenesisAccounts() error { | |||
| acc, err := gbc.arg.Accounts.LoadAccount(core.SystemAccountAddress) | |||
There was a problem hiding this comment.
why are you loading and saving the same accounts without any changes ?
There was a problem hiding this comment.
This is mandatory at genesis to have accounts initialized.
| @@ -77,6 +103,12 @@ func (gbc *sovereignGenesisBlockCreator) createSovereignEmptyGenesisBlocks() (ma | |||
| return mapEmptyGenesisBlocks, nil | |||
| } | |||
|
|
|||
| func createSovereignGenesisConfig() config.EnableEpochs { | |||
| cfg := createGenesisConfig() | |||
| cfg.ESDTMultiTransferEnableEpoch = 0 | |||
There was a problem hiding this comment.
I think we could return error if the config is wrong. instead of setting it to 0 here.
There was a problem hiding this comment.
This is not the loaded config from config.toml.
This is a "mocked" created config for sovereign bootStrapping at genesis.
There was a problem hiding this comment.
When we'll make the chain start correctly with every flag on epoch 0, we should also change this mocked config to return everything with enable epoch 0 as well
There was a problem hiding this comment.
Will add a task for this
…esdt-tokens # Conflicts: # genesis/process/sovereignGenesisBlockCreator.go # genesis/process/sovereignGenesisBlockCreator_test.go
Reasoning behind the pull request
depositidentifier from main chainProposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?