Skip to content

Commit

Permalink
FIX: Remove redundant GetDefaultRunTypeStub
Browse files Browse the repository at this point in the history
  • Loading branch information
mariusmihaic committed Oct 8, 2024
1 parent e29d6e8 commit c51e07c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 44 deletions.
5 changes: 2 additions & 3 deletions integrationTests/testConsensusNode.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import (
crypto "github.com/multiversx/mx-chain-crypto-go"
mclMultiSig "github.com/multiversx/mx-chain-crypto-go/signing/mcl/multisig"
"github.com/multiversx/mx-chain-crypto-go/signing/multisig"
"github.com/multiversx/mx-chain-go/testscommon/components"

"github.com/multiversx/mx-chain-go/config"
"github.com/multiversx/mx-chain-go/consensus"
Expand Down Expand Up @@ -240,8 +241,6 @@ func (tcn *TestConsensusNode) initNode(args ArgsTestConsensusNode) {

tcn.initAccountsDB()

runTypeComponents := GetDefaultRunTypeComponents(args.ConsensusModel)

coreComponents := GetDefaultCoreComponents(CreateEnableEpochsConfig())
coreComponents.SyncTimerField = syncer
coreComponents.RoundHandlerField = roundHandler
Expand Down Expand Up @@ -345,7 +344,7 @@ func (tcn *TestConsensusNode) initNode(args ArgsTestConsensusNode) {

var err error
tcn.Node, err = node.NewNode(
node.WithRunTypeComponents(runTypeComponents),
node.WithRunTypeComponents(components.GetRunTypeComponents()),
node.WithCoreComponents(coreComponents),
node.WithStatusCoreComponents(statusCoreComponents),
node.WithCryptoComponents(cryptoComponents),
Expand Down
41 changes: 0 additions & 41 deletions integrationTests/testProcessorNode.go
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ import (
"github.com/multiversx/mx-chain-go/update/trigger"
"github.com/multiversx/mx-chain-go/vm"
vmProcess "github.com/multiversx/mx-chain-go/vm/process"
"github.com/multiversx/mx-chain-go/vm/systemSmartContracts"
"github.com/multiversx/mx-chain-go/vm/systemSmartContracts/defaults"

"github.com/multiversx/mx-chain-core-go/core"
Expand Down Expand Up @@ -3357,46 +3356,6 @@ func CreateEnableEpochsConfig() config.EnableEpochs {
}
}

// GetDefaultRunTypeComponents -
func GetDefaultRunTypeComponents(consensusModel consensus.ConsensusModel) *mainFactoryMocks.RunTypeComponentsStub {
rt := components.GetRunTypeComponents()
return &mainFactoryMocks.RunTypeComponentsStub{
BlockChainHookHandlerFactory: rt.BlockChainHookHandlerCreator(),
BlockProcessorFactory: rt.BlockProcessorCreator(),
BlockTrackerFactory: rt.BlockTrackerCreator(),
BootstrapperFromStorageFactory: rt.BootstrapperFromStorageCreator(),
EpochStartBootstrapperFactory: rt.EpochStartBootstrapperCreator(),
ForkDetectorFactory: rt.ForkDetectorCreator(),
HeaderValidatorFactory: rt.HeaderValidatorCreator(),
RequestHandlerFactory: rt.RequestHandlerCreator(),
ScheduledTxsExecutionFactory: rt.ScheduledTxsExecutionCreator(),
TransactionCoordinatorFactory: rt.TransactionCoordinatorCreator(),
ValidatorStatisticsProcessorFactory: rt.ValidatorStatisticsProcessorCreator(),
AdditionalStorageServiceFactory: rt.AdditionalStorageServiceCreator(),
SCProcessorFactory: rt.SCProcessorCreator(),
BootstrapperFactory: rt.BootstrapperCreator(),
SCResultsPreProcessorFactory: rt.SCResultsPreProcessorCreator(),
AccountParser: rt.AccountsParser(),
AccountCreator: rt.AccountsCreator(),
VMContextCreatorHandler: systemSmartContracts.NewVMContextCreator(),
ConsensusModelType: consensusModel,
VmContainerMetaFactory: rt.VmContainerMetaFactoryCreator(),
VmContainerShardFactory: rt.VmContainerShardFactoryCreator(),
OutGoingOperationsPool: rt.OutGoingOperationsPoolHandler(),
DataCodec: rt.DataCodecHandler(),
TopicsChecker: rt.TopicsCheckerHandler(),
ShardCoordinatorFactory: rt.ShardCoordinatorCreator(),
NodesCoordinatorWithRaterFactory: rt.NodesCoordinatorWithRaterCreator(),
RequestersContainerFactory: rt.RequestersContainerFactoryCreator(),
InterceptorsContainerFactory: rt.InterceptorsContainerFactoryCreator(),
ShardResolversContainerFactory: rt.ShardResolversContainerFactoryCreator(),
TxPreProcessorFactory: rt.TxPreProcessorCreator(),
ExtraHeaderSigVerifier: rt.ExtraHeaderSigVerifierHolder(),
GenesisBlockFactory: rt.GenesisBlockCreatorFactory(),
GenesisMetaBlockChecker: rt.GenesisMetaBlockCheckerCreator(),
}
}

// GetDefaultCoreComponents -
func GetDefaultCoreComponents(enableEpochsConfig config.EnableEpochs) *mock.CoreComponentsStub {
genericEpochNotifier := forking.NewGenericEpochNotifier()
Expand Down

0 comments on commit c51e07c

Please sign in to comment.