-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Array mpc as service demo transformed to be a cypress test #277
Conversation
I found out the issue around socket connection due to the socket.io version update. Upon socket connection, JIFF register a callback, handlers.connect in client/socket/event.js #L11
After required number of all sockets are connected, it gets triggered by jiff-client-restful.js (This example uses restful extension instead of websockets).
This implementation worked fine in socket v2.5.0, because this.socket.on('connect', jiffClient.handlers.connected); registered the callbacks twice for a single connection for some reason. However, from v3 onward (we are currently using v4), it is no longer the case and this weird behavior has been corrected. The resulting listener array only contains 1 callback from itself. Therefore, I changed the starting index from i = 1 to i = 0, so that the only 'on connect' listener call back gets executed as intended:
|
No description provided.