Replacing unsupported/dropped mysql function PASSWORD() #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When is that file/class used? In other words, how do we test this? |
|
It came up running the unit tests. I don't know how to use that class - I'm guessing you can have user info (passwords) in text files on the filesystem (instead of having that info in the db). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mysql PASSWORD() function is no longer supported in mysql 8.x
There have been already pull requests to change the password hash in the DB. But the code in kernel/classes/datatypes/ezuser/eztextfileuser.php is an oversight. This pull request is hashing the password with the PHP function password_hash() and stores it together with the password_hash_type 7 in the DB.
The password_hash_type is the correct type for password hashes generated with the PHP function.