Moved shared icons into the admin design #202
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only slightly related: That share/icons folder is my default place to put temporary files to download. I guess I can find a different folder! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eZ Publish has a theme concept for icons. The icon files are located at share/icons/.... In the apache vhost configuration we allow a direct access to icons folder.
I do not know a single site that is using multiple icon themes actively. Sometimes we added more icons for content classes - so that we have special icons in the admin interface for custom classes we created for clients.
This pull requests simplifies the approach to the icons. It is moving the icons of the crystal-admin theme into the admin design extension. The template operators in order to build the URL to the icon images are updated and lookup the icons in the admin design (instead of looking them up in the share/icons folder).
The benefit is less complexity, icon images are handled as any other design images (there is still the access through the template operators). No special rule in the vhost is needed anymore.