Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(output): export output writer #122

Merged
merged 1 commit into from
Aug 25, 2023
Merged

fix(output): export output writer #122

merged 1 commit into from
Aug 25, 2023

Commits on Aug 22, 2023

  1. fix(output): export output writer

    Termenv output can be a buffer, ssh session, a file, or anything that
    implements the io.Writer interface.
    
    In the case of an ssh session, the std ssh library returns a
    io.ReadWriter for ssh sessions and the current Termenv implementation
    makes it impossible to read terminal status reports since it expects a
    file in return.
    
    In addition, the TTY() function is confusing since it implies that the
    returned value is a TTY. Which is not always true until we check that
    using the isTTY() function.
    
    Deprecate TTY() in favor of Writer() which simply returns the underlying
    writer. The caller then can infer the type of the writer and decide what
    to do with it.
    
    This also deprecate parts of commit 669c9ab 669c9ab
    aymanbagabas committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    30e443b View commit details
    Browse the repository at this point in the history