Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move handle_info fallback handler to end of compilation to allow override #105

Merged
merged 1 commit into from
Dec 31, 2023
Merged

Move handle_info fallback handler to end of compilation to allow override #105

merged 1 commit into from
Dec 31, 2023

Conversation

mtrudel
Copy link
Owner

@mtrudel mtrudel commented Dec 31, 2023

Refines the feature added in #96

Fixes #104

Would appreciate a review @dch, @elfenlaid, @ryanwinchester, anyone else!

ryanwinchester
ryanwinchester approved these changes Dec 31, 2023
View reviewed changes
Copy link

@ryanwinchester ryanwinchester left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me 🚀

@elfenlaid
Copy link
Contributor

yeap, looks good 🙌

@mtrudel mtrudel merged commit 87f287f into main Dec 31, 2023
9 checks passed
@mtrudel mtrudel deleted the fallback_message_fix branch December 31, 2023 17:29
@mtrudel
Copy link
Owner Author

mtrudel commented Dec 31, 2023

Released in 1.3.2

@dch
Copy link
Contributor

dch commented Jan 5, 2024

thanks @mtrudel this @before_compile trick works perfectly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanwinchester ryanwinchester ryanwinchester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

handling non-TI messages within same GenServer fails after PR#96
4 participants
@mtrudel @elfenlaid @dch @ryanwinchester