Support ISO8601 without timezone #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrudel
reviewed
Apr 21, 2024
Comment on lines
96
to
100
| _ -> | ||
| case NaiveDateTime.from_iso8601(b) do | ||
| {:ok, naive_datetime_b} -> naive_datetime_b ~>> naive_datetime(a.datetime_opts) | ||
| _ -> mismatch("#{inspect(b)} is not a parseable ISO8601 datetime") | ||
| end |
There was a problem hiding this comment.
This ends up possibly matching naive 8601s when you otherwise may not have meant to (TBH, I'd never realized 8601s were valid without a timezone until you brought it up!). I agree that this belongs in this matcher, but maybe hidden behind a flag? 8601 calls that last component an 'offset', so maybe something like offset_required, defaulting to true?
There was a problem hiding this comment.
Yeah that makes sense, I've now added it as an option 👍
|
Looks great! Thanks Jason! |
|
Published as 0.3.1 |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends
Machete.ISO8601DateTimeMatcherto support ISO8601 timestamps without a timezone (such as those thatNaiveDateTime.to_iso8601/1creates.Fixes #30
After this PR this is the behavior we get: