Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change {image}_updated_at to Time (was DateTime) #83

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnnyshields
Copy link

@johnnyshields johnnyshields commented Aug 26, 2023

For {image}_updated_at field, type Time is better to use than DateTime.

  • It has better performance
  • It's what Mongoid uses for created_at / updated_at timestamps.
  • This change can be done without needing to migrate the data in the database.
  • For the vast majority of apps this will not have an real impact, since ActiveSupport standardizes the main methods of Time/DateTime.

@dshoemaker
Copy link

@mrrooijen any chance this change could get an approval? We're leveraging this gem and attempting to follow Ruby's soft deprecation of DateTime in favor of Time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants