-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Origination fees on borrow #239
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgur-psyops
commented
Aug 22, 2024
…repayment math (avoid fractional debt due to the fee)
jgur-psyops
commented
Aug 24, 2024
LevBeta
reviewed
Aug 28, 2024
jkbpvsc
reviewed
Aug 28, 2024
jkbpvsc
reviewed
Aug 28, 2024
jkbpvsc
requested changes
Aug 28, 2024
jkbpvsc
requested changes
Oct 22, 2024
jkbpvsc
previously approved these changes
Oct 22, 2024
…, as dictated in the program_fee_rate
jkbpvsc
approved these changes
Oct 23, 2024
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A per-bank configurable origination fee that is immediately
paid to the fee vaultrecorded on the bank upon any borrow.Suggest deferring merge until after Switchboard pull deployment.
Other items:
configure_bank
(add new rate toInterestRateConfigOpt
)Changes which will require FE/api integration:
Adds an account to the borrow ix (the fee vault)bank.config.interest_rate_config.protocol_origination_fee