Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Origination fees on borrow #239

Merged
merged 18 commits into from
Oct 23, 2024
Merged

Origination fees on borrow #239

merged 18 commits into from
Oct 23, 2024

Conversation

jgur-psyops
Copy link
Contributor

@jgur-psyops jgur-psyops commented Aug 22, 2024

A per-bank configurable origination fee that is immediately paid to the fee vault recorded on the bank upon any borrow.

Suggest deferring merge until after Switchboard pull deployment.

Other items:

  • Add ability to configure interest rates of existing banks via configure_bank (add new rate to InterestRateConfigOpt)
  • Add new fields to fuzz test suite
  • Add tests with non-zero origination fee

Changes which will require FE/api integration:

  • Adds an account to the borrow ix (the fee vault)
  • Banks now have a new field: bank.config.interest_rate_config.protocol_origination_fee
  • (maybe) Migrate existing banks to take on the new fee

@jgur-psyops jgur-psyops added the enhancement New feature or request label Aug 22, 2024
jkbpvsc
jkbpvsc previously approved these changes Oct 22, 2024
@jgur-psyops jgur-psyops merged commit f51c25a into main Oct 23, 2024
4 checks passed
@jgur-psyops jgur-psyops deleted the origination-fees branch October 23, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants