More flexible flashloan health check #213
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With these changes, a flashloan can be initialized regardless of account health. However, a flashloan can only be finalized if one of following conditions are true:
Note that we don't simply check if health improved. as users should be allowed to worsen their health in case 1 so long as their account started and ended in good health. To facilitate the check in 2), 16 bytes have been taken from the marginfi account padding to store the account health at the start of the flashloan.
Testing
This PR adds two tests for flashloans for accounts that begin in bad health: