-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flashloans #121
Merged
Merged
Flashloans #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One consideration I'm having is if we should have all the borrows and repays happen in the |
…ted-deposits' into 142-ignore-stale-banks-for-isolated-deposits
jkbpvsc
added a commit
that referenced
this pull request
Oct 15, 2024
* feat: flashloans * fix: RiskEngine constructor * fix: clippy fix * fix: test setup, set account flags ixs * fix: flashloans test * fix: more tests * fix: even more tests * fix: fmt + anchor lint * fix: fmt * fix: cli imports * feat: reworked risk engine value calculations * fix: update imports, correct log name * fix: fix indexer * fix: use correct oracle type for price bands * fix: format * fix: again with cyrills unreasonable demands * fix: check start and end flashloan ixs are not in CPI * fix: add tests * fix: fmt * fix: update indexer, and cli * fix: fuzz tests * fix: fuzzer generation * fix: fuzz github action * fix: action * fix: actions * fix: temp disabled manual actions * fix: install cargo fuzz * fix: gha * fix: assert start and end fl ix are not in CPI * fix: nit --------- Co-authored-by: j <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flashloans
How they work
Flashloans work by deferring health checks for an account to the end of the flashloan. This is achieved with two new instructions.
flashloan_start
andflashloan_end
.flashloan_start
- performs a number of security checks, set theIN_FLASHLOAN_FLAG
flashloan_end
- checks the account health, and clears theIN_FLASHLOAN_FLAG
Security checklist
end_flashloan
ix index is afterstart_flashloan
ix indexend_flashloan
ix presentend_flashloan
ix is for the marginfi programend_flashloan
ix is for the same marginfi accountConsiderations