-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change set_rtss_epi to set_pev_epi #16
Conversation
@lmhaile - we need the checks below to be passing before these changes can be brought in. Given that we have made modifications to the vaccine implementation, it is likely that the associated test will also have to be corrected, that is in this file: https://github.com/mrc-ide/site/blob/main/tests/testthat/test-rtss.R. You can read here (https://r-pkgs.org/testing-basics.html) for more info on unit tests in packages if it is new to you. |
parameters = p, | ||
profile = rtss_profile, | ||
timesteps = timesteps, | ||
coverages = interventions$rtss_cov, | ||
age = round(6 * month), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some pieces missing here, if we look at https://mrc-ide.github.io/malariasimulation/articles/Vaccines.html#simulation-2 then we need to:
- additionally specify the
booster_profile
- rename the
boosters
argument tobooster_timestep
-
seasonal_boosters
is by default set toFALSE
so we can remove that
In addition, it might be nice to add a plot to this PR showing the two site files runs - one with vaccination and one without. That way we can be more cofident that the vaccine implementation if feeding through to the model as expected |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
==========================================
+ Coverage 96.55% 96.56% +0.01%
==========================================
Files 9 9
Lines 232 233 +1
==========================================
+ Hits 224 225 +1
Misses 8 8
☔ View full report in Codecov by Sentry. |
Quick change per the new malariasimulation version!