Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows username to api and configuration #46

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Add windows username to api and configuration #46

merged 2 commits into from
Jan 3, 2024

Conversation

richfitz
Copy link
Member

@richfitz richfitz commented Jan 3, 2024

Merge after #40, contains those commits

This PR adds a helper function windows_username() which returns the username, and then uses that function to add the username into the reported configuration from hipercow_configuration()

@richfitz richfitz marked this pull request as ready for review January 3, 2024 10:21
Copy link
Contributor

@weshinsley weshinsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - additionally tested it by windows_authenticate() with both my "normal" and "admin" usernames, and in each case, correct user name was reported. (Not many people will have two valid windows usernames)

@weshinsley weshinsley merged commit 962c89e into main Jan 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants