Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow advertising of globals #29

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Allow advertising of globals #29

merged 4 commits into from
Dec 18, 2023

Conversation

richfitz
Copy link
Member

@richfitz richfitz commented Dec 18, 2023 •
edited
Loading

This PR lets the user declare what variables we can rely on to exist within their created environment. There's a special value TRUE here which just builds the env and works it out

@richfitz richfitz marked this pull request as ready for review December 18, 2023 11:28
weshinsley
weshinsley approved these changes Dec 18, 2023
View reviewed changes
R/environment.R Outdated Show resolved Hide resolved
tests/testthat/test-environment.R Show resolved Hide resolved
tests/testthat/test-interface.R Outdated Show resolved Hide resolved
R/environment.R Outdated Show resolved Hide resolved
@weshinsley weshinsley self-requested a review December 18, 2023 12:38
weshinsley
weshinsley approved these changes Dec 18, 2023
View reviewed changes
tests/testthat/test-environment.R Show resolved Hide resolved
tests/testthat/test-interface.R Outdated Show resolved Hide resolved
@weshinsley weshinsley merged commit 6fef641 into main Dec 18, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshinsley weshinsley weshinsley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richfitz @weshinsley