Export windows functions directly from hermod #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 9 +1
Lines 354 357 +3
=========================================
+ Hits 354 357 +3 ☔ View full report in Codecov by Sentry. |
weshinsley
approved these changes
Dec 13, 2023
| ##' @param drive_remote The place to mount the drive on the cluster. | ||
| ##' We're probably going to mount things at Q: and T: already so | ||
| ##' don't use those. And things like C: are likely to be used. | ||
| ##' Perhaps there are some guidelines for this somewhere? |
There was a problem hiding this comment.
Future to-dos -
- Should we have a ticket to write this guidance and improve that last sentence!
- Should we outlaw
I:here? - I slightly feel we should drift away from the temp drive, but perhaps not quite ready to shout that yet.
There was a problem hiding this comment.
- https://mrc-ide.myjetbrains.com/youtrack/issue/mrc-4790 - added a ticket for
I: - https://mrc-ide.myjetbrains.com/youtrack/issue/mrc-4791 - for docs
For the temp drive we can probably just softly move away from it?
| "only need to call 'library(hermod)'") | ||
| packageStartupMessage(paste(strwrap(msg), collapse = "\n")) | ||
| # nocov end | ||
| } |
Co-authored-by: Wes Hinsley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package prevents users needing to interact at all with hermod.windows - hermod becomes the wrapper for the call