Mrc 5429 - warn on "..." specified for null driver in hipercow_init #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richfitz
requested changes
Jul 8, 2024
R/root.R
Outdated
| @@ -24,6 +24,16 @@ | |||
| ##' path <- withr::local_tempfile() | |||
| ##' hipercow_init(path) | |||
| hipercow_init <- function(root = ".", driver = NULL, ...) { | |||
| if ((is.null(driver)) && (length(list(...)) > 0)) { | |||
There was a problem hiding this comment.
Perhaps look into rlang::check_dots_used (https://rlang.r-lib.org/reference/check_dots_used.html) which might do this for us?
There was a problem hiding this comment.
There is the possibility of...
if (is.null(driver)) {
rlang::check_dots_empty()
}
but converting this from an error to a warning, and including a message to say why
! ... must be empty.
only applies when driver = NULL was a bit fiddly.
richfitz
requested changes
Jul 8, 2024
Co-authored-by: Rich FitzJohn <[email protected]>
richfitz
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.