Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression Test Heap Optimization: Remove Extinct Result Arrays #433

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Regression Test Heap Optimization: Remove Extinct Result Arrays #433

wants to merge 1 commit into from

Commits on Jul 1, 2020

  1. this commit removes the TSMeanE and TSVarE arrays from the code since… 

    … they are not currently used in the final output; the size of the Results struct is somewhere around 800 KB, which when accounting P.NumSamples (720 in the regression tests) means that TSMeanE and TSVarE each require an allocation of around 580 MB; as a result, the regression tests when run in parallel will use 1160 x 4 = 4640 MB or 4.53 GB less than they were before; this allows the default GitHub action runners which have only 7 GB total to be able to run all 4 tests without having to page memory to disk
    @ozmorph
    ozmorph committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    e22ecf8 View commit details
    Browse the repository at this point in the history