Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add individual state level admin files #286

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jhelie
Copy link
Collaborator

@jhelie jhelie commented May 19, 2020

This adds the state level admin files that are generated on the fly by the UI. @gorzell I've noticed that the [Population size] is always equal to the total US pop size (338798532): is it something that should be changed?
(for the few files which were already in the repo and that I've simply moved, such as Alaska_admin.txt or Hawaii_admin.txt, the number seems to reflect the actual population of the admin unit).

Copy link
Collaborator

@matt-gretton-dann matt-gretton-dann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To save me the pain of modifying the scrpting - can these all just be put in the top-level admin_units directory and not put further down?

@weshinsley
Copy link
Collaborator

weshinsley commented Jun 24, 2020

@matt-gretton-dann - this PR fell asleep - I've moved the USA files back into the top level.

@dlaydon - I can't remember whether [Population size] for these state level files should be USA population, or state specific, or whether it matters - it'll be loading the different states out of the same wpop file... (except for the non "mainland-USA" - Alaska, Hawaii, Guam, Virgin Islands US, Puerto Rico, which have their [Population size] set specifically already)

The more I think about it, the more I think this is correct; that the states dug out of the "all-US" wpop file (with the extra schools data) should have the Population Size set to USA, and the others shouldn't - which is what we have... but would be good to confirm

@matt-gretton-dann
Copy link
Collaborator

matt-gretton-dann commented Jun 24, 2020

@matt-gretton-dann - this PR fell asleep - I've moved the USA files back into the top level.

@dlaydon - I can't remember whether [Population size] for these state level files should be USA population, or state specific, or whether it matters - it'll be loading the different states out of the same wpop file... (except for the non "mainland-USA" - Alaska, Hawaii, Guam, Virgin Islands US, Puerto Rico, which have their [Population size] set specifically already)

The more I think about it, the more I think this is correct; that the states dug out of the "all-US" wpop file (with the extra schools data) should have the Population Size set to USA, and the others shouldn't - which is what we have... but would be good to confirm

@weshinsley, @dlaydon: How does the [Fix population size at specified value] setting interact with the population size?

I need to update stuff the run_sample.py scripts to understand which wpop files to use for these files.

@matt-gretton-dann matt-gretton-dann changed the base branch from matt-gretton-dann/full_run_sample.py to master June 24, 2020 15:38
@matt-gretton-dann
Copy link
Collaborator

I have retargeted this to mainline as well (it was targeted at one of my own branches).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants