Fixed compatibility issue in clicker #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_clicker used python syntax that is only compatible with python 3.10+. I changed the syntax to be compatible with earlier versions. My research group uses this epon source library with python 3.9.6 and are glad to contribute. Package now requires the typing module as a dependency. Committer Contact info: H. Ryott Glayzer email: [email protected]
for more information, see https://pre-commit.ci
ianhi
requested changes
Jan 31, 2024
There was a problem hiding this comment.
Hi Ryott,
thanks for opening a PR to fix this! Sorry I i foolishly didn't test older python versions, that was a mistake.
I'd prefer to fix this by putting a from __future__ import annotations at the top of the file rather than using the older syntax.
If you have time could you change to that fix? If you don't have the time that's also ok, just let me know and I'll take this PR to the finish line
|
Just updated the pr. Let me know if you need anything else
…On Wed, Jan 31, 2024 at 12:53 PM Ian Hunt-Isaak ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Hi Ryott,
thanks for opening a PR to fix this! Sorry I i foolishly didn't test older
python versions, that was a mistake.
I'd prefer to fix this by putting a from __future__ import annotations at
the top of the file rather than using the older syntax.
If you have time could you change to that fix? If you don't have the time
that's also ok, just let me know and I'll take this PR to the finish line
—
Reply to this email directly, view it on GitHub
<#19 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5PZJWRH6YOBLNIF6Z4R5OTYRKOKVAVCNFSM6AAAAABCQEHD2GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNJUG4YDQMJZG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
*H. Ryott Glayzer*
*She/Her*
Physics Student
Lab Assistant
SD Mines
Mobile: +1 605 858 3899
*This email was formatted using TeX for Gmail.*
|
ianhi
reviewed
Jan 31, 2024
ianhi
approved these changes
Jan 31, 2024
|
Just released! on pypi as version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_clicker used python syntax that is only compatible with python 3.10+. I changed the syntax to be compatible with earlier versions. My research group uses this open source library with python 3.9.6 and are glad to contribute.
Package now requires the typing module as a dependency.
Committer Contact info:
H. Ryott Glayzer, she/her
email: [email protected]