Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: add card link in card header #8

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

luckylionheart
Copy link

No description provided.

app/app.view.ts Outdated Show resolved Hide resolved
app/app.view.ts Outdated Show resolved Hide resolved
Copy link
Member

@blokhin blokhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luckylionheart see minor suggestions above

@luckylionheart
Copy link
Author

@blokhin I think, I have done this issues. Please check it and confirm PR. Thanks

@blokhin
Copy link
Member

blokhin commented Jul 21, 2024

@luckylionheart after some tests I indeed figured out that the link in the card header is problematic for swiping... please, could we move it to the top header Does this material exist?, so that the words this material are linked?

@blokhin
Copy link
Member

blokhin commented Jul 21, 2024

@luckylionheart I believe, this is the required app.view.tree snippet:

		<= Head_space $mol_view
			sub /
				<= Head_card $mol_list
					sub / <= Head_title $mol_paragraph
						sub /
							\Does
							<= Head_link $mol_link
								uri <= title_link \
								sub /
									\this material
							\exist?

@luckylionheart
Copy link
Author

@blokhin check this PR.
Add the link for this material

@blokhin
Copy link
Member

blokhin commented Aug 10, 2024

@luckylionheart many thanks... why does not it work anymore?

@luckylionheart
Copy link
Author

luckylionheart commented Aug 12, 2024

@luckylionheart many thanks... why does not it work anymore?

@blokhin sorry, let me check again.

@luckylionheart
Copy link
Author

@blokhin sorry, let me check again.

@blokhin could you check a live site?
https://mpds-io.github.io/this-material-does-not-exist/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants