exclude inner field if no inner error provided

The undefined inner field can result in bogus assertion failures when writing tests using this error-strategy.
mpareja · Jul 5, 2019 · f33cf57 · f33cf57
1 parent d8560df
commit f33cf57
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -20,7 +20,9 @@ for (let { type, code } of errors) {
   module.exports[type] = (msg, inner) => {
     const error = new Error(msg)
     error.code = code
-    error.inner = inner
+    if (inner) {
+      error.inner = inner
+    }
     return error
   }
 }

diff --git a/test/grpc-error-strategy.test.js b/test/grpc-error-strategy.test.js
@@ -84,5 +84,10 @@ function testError ({ type, code }) {
       const error = GrpcErrorStrategy[type](A_DESCRIPTION, inner)
       expect(error.inner).toBe(inner)
     })
+
+    it('excludes inner key if none provider', () => {
+      const error = GrpcErrorStrategy[type](A_DESCRIPTION)
+      expect(error).not.toHaveProperty('inner')
+    })
   })
 }